Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email )
Change subject: pcap-server: Make rotate-localtime feature configurable through VTY
......................................................................
Patch Set 5:
(2 comments)
File src/osmo_server_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/a4a1b17e_99e130eb?us… :
PS3, Line 231: /* Checks if we are in a new record period since last time we wrote to a
pcap, to know (return true) whether a new pcap file needs to be opened.
Acknowledged
Done
File src/osmo_server_vty.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/6cef74db_959faa46?us… :
PS3, Line 219: frecuency
Acknowledged
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73
Gerrit-Change-Number: 39158
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Dec 2024 11:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>