pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email )
Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count ......................................................................
bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
Even with latest changes I can still sometimes run into up to 6 FNs less than the currently minimum expected. That's usually 1-2 primitives less, which in the number of >1000 we are receiving over 5 seconds, seems like a plausible drift.
Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 --- M bts/BTS_Tests.ttcn 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/41783/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index bf59eb8..b43706c 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6101,7 +6101,7 @@ /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS; - var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 20); + var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 30); if (not match(fn_expired, t_fn_expected)) { setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not matching ", t_fn_expected); } @@ -6135,6 +6135,7 @@ T.start(test_duration); alt { [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?)) { + log("PESPIN: Rx PDTCH ", msg.u.rts_req.fn); num_rts_pdtch := num_rts_pdtch + 1; if (isbound(pdtch_first_fn)) { var integer exp_fn := f_next_pdtch_block(pdtch_last_fn); @@ -6151,6 +6152,7 @@ repeat; } [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?)) { + log("PESPIN: Rx PTCCH ", msg.u.rts_req.fn); num_rts_ptcch := num_rts_ptcch + 1; if (isbound(ptcch_first_fn)) { var integer exp_fn := f_next_ptcch_dl_block(ptcch_last_fn); @@ -6189,7 +6191,7 @@ /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS; - var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 20); + var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 30); if (not match(fn_expired, t_fn_expected)) { setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not matching ", t_fn_expected); }