5 Sep
2022
5 Sep
'22
3:32 p.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266 )
Change subject: Pass AMR codec info over L1CTL
......................................................................
Patch Set 4: Code-Review+1
(4 comments)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/9dfab72c_1f1d…
PS2, Line 2513: 0
Can also be made configurable via
g_pars.amr_start_codec.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/e18900c4_a821…
PS2, Line 2521: 00000100
I suggest to make this value configurable via
g_pars.amr_codecs.
Done
File library/L1CTL_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/e09f345c_3178…
PS2, Line 184: start_codec
Either prefix both fields with 'amr_', or wrap
into a record: […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/211f0de4_ab7d…
PS2, Line 288: start_codec
Same here. You may also define it as a separate record
to avoid code dup.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3db7f6a4b7819b16ada83862f2a5409db4fa21f9
Gerrit-Change-Number: 29266
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 15:32:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment