Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 )
Change subject: Use osmo_sockaddr_strs_to_str() for multiaddr helper ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
What do we win with this? I see only drawbacks: allocating and freeing N more buffers on the heap ev […]
We gain decrease of code duplication - we use the same function which is also used in other place in the follow-up patches. I don't think heap alloc matter - that code is called only at the socket init and the number of sockets is a limited resource so it's very unlikely to ever end up on a hot codepath.