[M] Change in libosmo-abis[master]: trau: new function osmo_trau2rtp_ufe()

Attention is currently required from: falconia, fixeria, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email ) Change subject: trau: new function osmo_trau2rtp_ufe() ...................................................................... Patch Set 2: (8 comments) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/70624bbd_9a2f4402… : PS2, Line 137: * \param[in] emit_twts001 self-explanatory It may be self explanatory to you, but no to others. Please add something like: "Generate RTP in TW-TS-001 format" or whatever the name of the spec it is. Also some reference to where that spec may be found may be useful. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/fdc67bf4_d40bb9ab… : PS2, Line 249: * \param[in] emit_twts002 self-explanatory Same, not self-explanatory. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/709a0765_7e449ffe… : PS2, Line 260: return -EINVAL; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/2f37b122_7e897240… : PS2, Line 263: return -ENOSPC; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/0e5f26ca_73593e19… : PS2, Line 282: return 0; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/efec54d5_b24b092f… : PS2, Line 299: return 1; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/2355f03b_455a8f19… : PS2, Line 311: return GSM_HR_BYTES_RTP_RFC5993; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03… : PS2, Line 359: Let's better initialize ufe always if present, to avoid uninitialized memory. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9 Gerrit-Change-Number: 39731 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Mar 2025 12:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No