Attention is currently required from: falconia, fixeria, laforge.

View Change

8 comments:

• File src/trau/trau_rtp_conv.c:

  • Patch Set #2, Line 137: * \param[in] emit_twts001 self-explanatory

    It may be self explanatory to you, but no to others.
    Please add something like: "Generate RTP in TW-TS-001 format" or whatever the name of the spec it is. Also some reference to where that spec may be found may be useful.

  • Patch Set #2, Line 249: * \param[in] emit_twts002 self-explanatory

    Same, not self-explanatory.

  • Patch Set #2, Line 260: return -EINVAL;

    ufe is left uninitialized here.

  • Patch Set #2, Line 263: return -ENOSPC;

    ufe is left uninitialized here.

  • Patch Set #2, Line 282: return 0;

    ufe is left uninitialized here.

  • Patch Set #2, Line 299: return 1;

    ufe is left uninitialized here.

  • Patch Set #2, Line 311: return GSM_HR_BYTES_RTP_RFC5993;

    ufe is left uninitialized here.

  • Patch Set #2, Line 359:

    Let's better initialize ufe always if present, to avoid uninitialized memory.

To view, visit change 39731. To unsubscribe, or for help writing mail filters, visit settings.