Attention is currently required from: fixeria.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email )
Change subject: codec: add osmo_hr_sid_classify() ......................................................................
Patch Set 2:
(2 comments)
File src/codec/hr_sid_class.c:
https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/817ad5f5_40c36ba5 PS2, Line 35: for (; byte; byte >>= 1) {
This is absolutely fine for not so hot code paths, but if this is to be done for each byte of each R […]
Thanks for the recommendation - I will implement it in the next revision of this patch.
https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/8839cf1e_7a40cc4c PS2, Line 144: class1_ones = sid_field_ones - class2_ones;
I am wondering if, in theory, `class2_ones` can be greater than `sid_field_ones`? […]
No, `class2_ones` can never be greater than `sid_field_ones` because the definition of SID field for HRv1 (GSM 06.22) includes all 17 class 2 bits plus some (62 out of 95) class 1 bits.