Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28193 )
Change subject: cosmetic: iuup.h: Fix indentation
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/iuup.h:
https://gerrit.osmocom.org/c/libosmocore/+/28193/comment/735c5bc3_8dffa31e
PS1, Line 45: struct osmo_iuup_rfci {
I think we also need to handle little/big endian here?
No, that's not a compacted struct used in the wire. It's just done this way
to save some space since there's actually an array of them (64) for each conn.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28193
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I10a2d2a872fd6fdae8b4af94995300af3144b551
Gerrit-Change-Number: 28193
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 May 2022 11:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment