Attention is currently required from: osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email )
Change subject: add IPv6 support ......................................................................
Patch Set 1:
(1 comment)
File include/linux/gtp.h:
https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/df2ba139_0260363b PS1, Line 27: #define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
I'm not sure I'm following here. […]
The kernel code used to call it GTPA_SGSN_ADDRESS initially at the time the kernel GTP only supported the "GGSN role". We later renamed it to the more generic PEER_ADDRESS when introducing support for SGSN role to kernel GTP.
See linux.git:
commit ae6336b57ede8cdf801b04e6d943617bb945e3f9 Author: Jonas Bonn jonas@southpole.se Date: Fri Mar 24 23:23:20 2017 +0100
gtp: rename SGSN netlink attribute
Which contains
- GTPA_SGSN_ADDRESS, + GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */ +#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
I don't know why in libgtpnl we didn't introduce the compat #define in
commit 6e9afbbc3037c9e003260077b33dad202d5c55df Author: Jonas Bonn jonas@southpole.se Date: Fri Mar 24 15:19:19 2017 +0100
-- in any case, I think we can continue to live without that #define in userspace, or we simply add it here to avoid any confusing diff to the kernel header file.