Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: add IPv6 support ...................................................................... Patch Set 1: (1 comment) File include/linux/gtp.h: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/df2ba139_0260363b PS1, Line 27: #define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
I'm not sure I'm following here. […] The kernel code used to call it GTPA_SGSN_ADDRESS initially at the time the kernel GTP only supported the "GGSN role". We later renamed it to the more generic PEER_ADDRESS when introducing support for SGSN role to kernel GTP.
See linux.git: commit ae6336b57ede8cdf801b04e6d943617bb945e3f9 Author: Jonas Bonn <jonas@southpole.se> Date: Fri Mar 24 23:23:20 2017 +0100 gtp: rename SGSN netlink attribute Which contains - GTPA_SGSN_ADDRESS, + GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */ +#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */ I don't know why in libgtpnl we didn't introduce the compat #define in commit 6e9afbbc3037c9e003260077b33dad202d5c55df Author: Jonas Bonn <jonas@southpole.se> Date: Fri Mar 24 15:19:19 2017 +0100 -- in any case, I think we can continue to live without that #define in userspace, or we simply add it here to avoid any confusing diff to the kernel header file. -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:18:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment