Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33087 )
Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc
......................................................................
Patch Set 5:
(3 comments)
File include/osmocom/crypt/auth.h:
https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/ac9ac0ef_d467dc6c
PS4, Line 66: /* deprecated older structure without support for 32-byte K/OP[c] */
BTW, you can attach `OSMO_DEPRECATED` to structures
too. […]
Done
File src/gsm/auth_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/ff8bf97f_b8dd6093
PS4, Line 219: auth_data2auth_data2
check return value?
Done
https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/5f401068_72c33845
PS4, Line 285: auth_data2auth_data2
check return value?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/33087
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df
Gerrit-Change-Number: 33087
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Jun 2023 13:33:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment