15 Jun
2024
15 Jun
'24
11:01 p.m.
Attention is currently required from: neels, osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email )
Change subject: Osmocom_CTRL: counters: return -1 for absent objects ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
the reason why I like the implicit -1 is exactly because it is so simple and elegantly "docking" to […]
The proposed approach looks acceptable to me, so CR+1 from me. I see analogy with `kw.get(field, default)` in Python.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id00bbfe721d453e5f551e6d47e1b1d03d219700b
Gerrit-Change-Number: 37189
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Sat, 15 Jun 2024 21:01:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment