16 Feb
2026
16 Feb
'26
9:39 a.m.
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email )
Change subject: xua_asp_fsm: Validate remote ASP Id matching config in SG role ......................................................................
Patch Set 2:
(1 comment)
File src/xua_asp_fsm.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119/comment/52c849d7_769511... : PS2, Line 572: LOGL_NOTICE
Shouldn't this be LOGL_ERROR? Same below in the new log line.
In general I think this kind of logging coming from received messages should not log ERROR, since it's not really an internal error, but something unexpected received from a peer.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I3e22439aa7e22f7a6113b093c44ace6745c808b9
Gerrit-Change-Number: 42119
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Mon, 16 Feb 2026 09:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de