Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30996 )
Change subject: layer23: Initial integration of tun device ......................................................................
Patch Set 3:
(2 comments)
File src/host/layer23/src/common/apn.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/0d350cbd_4c768368 PS3, Line 88: /* TODO: prepare & transmit SNDCP UNITDATA.req */
unresolved TODO on purpose?
Yes, this will be a follow-up step (actually another set of patches perhaps).
https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/49da02bc_9df1c524 PS3, Line 94: what
use "flags" instead of "what" here, so it's more descriptive? I realize that it's also "what" in lib […]
what is fine here imho, otherwise it may be confused with other types of flags, like recv()/send() ones.