Attention is currently required from: osmith.

View Change

2 comments:

• File src/host/layer23/src/common/apn.c:

  • Patch Set #3, Line 88: /* TODO: prepare & transmit SNDCP UNITDATA.req */

    unresolved TODO on purpose?

    Yes, this will be a follow-up step (actually another set of patches perhaps).

  • Patch Set #3, Line 94: what

    use "flags" instead of "what" here, so it's more descriptive? I realize that it's also "what" in lib […]

    what is fine here imho, otherwise it may be confused with other types of flags, like recv()/send() ones.

To view, visit change 30996. To unsubscribe, or for help writing mail filters, visit settings.