Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32358 )
Change subject: ms: Make ms_{attach,detach}_tbf expectancies more robust ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/32358/comment/ddcb1201_fe327e75 PS2, Line 9: attach attached?
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32358/comment/c4cf4d99_8aa069c9 PS2, Line 355: OSMO_ASSERT(ms); Somehow it feels wrong when I am seeing a function assert()ing all its pointer arguments. As if I am reading the source code of open5gs-pcud...
https://gerrit.osmocom.org/c/osmo-pcu/+/32358/comment/d9d2e04b_36450829 PS2, Line 409: OSMO_ASSERT(!ms_tbf_is_attached(ms, tbf)); ... especially when some calling functions also do assert the arguments too.
https://gerrit.osmocom.org/c/osmo-pcu/+/32358/comment/14b78855_4be1082c PS2, Line 419: OSMO_ASSERT(tbf_ms(tbf) == ms); ... and here you're dereferencing tbf before assert()ing it.