Attention is currently required from: pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 9: attach

    attached?

• File src/gprs_ms.c:

  • Patch Set #2, Line 355: OSMO_ASSERT(ms);

    Somehow it feels wrong when I am seeing a function assert()ing all its pointer arguments.
    As if I am reading the source code of open5gs-pcud...

  • Patch Set #2, Line 409: OSMO_ASSERT(!ms_tbf_is_attached(ms, tbf));

    ... especially when some calling functions also do assert the arguments too.

  • Patch Set #2, Line 419: OSMO_ASSERT(tbf_ms(tbf) == ms);

    ... and here you're dereferencing tbf before assert()ing it.

To view, visit change 32358. To unsubscribe, or for help writing mail filters, visit settings.