Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29384 )
Change subject: vty doc: indicate default nft table name ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-upf/upf_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/29384/comment/669f951d_af3c6f42 PS2, Line 239: "Set the nft inet table name to create and place GTP tunnel forwarding chains in"
IMO, the interactive VTY help is not the right place for such a verbose explanation. […]
The VTY actually is a *good* place for verbose explanation: The explanations written here are placed in the vty-reference PDF, where there is unlimited space; the more concise information written in the VTY reference document, the better. On the live telnet vty prompt, long explanations are nicely structured with line breaks; The doc is only shown on explicit user request. No reason to be brief. So here, also, complete explanations are a good thing.
My general opinion is that there should be a lot more verbose explanations in the vty doc.