Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email )
Change subject: do not invoke two Assignments (fixup for re-assignment) ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: This patch may actually be more clear if you spit it into 2 steps (no need to really the change the code I think). In any case, explaining here to make sure I got it right: 1- Implement tear down due to Assignment timeout (the timer thing you added) 2- Avoid invoking concurrent Assignments (actually 2-3 line patch)
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/37272/comment/7bf3ccde_c7e1f871 PS1, Line 962: osmo_timer_del(&msc_a->cc.assignment_request_pending); is it fine calling osmo_timer_del for a timer object which may not have gone through osmo_timer_setup() (line 694) ?