Attention is currently required from: fixeria, lynxis lazus.
laforge has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email )
Change subject: gprs_gmm_util: add parsing of GMM Attach Requests
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/sgsn/gprs_gmm_util.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/3eb5a0eb_2e318ea5?us… :
PS3, Line 93: l3 pointers must point to gmm
l3 pointer of msgb must point to the (start of) GMM
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/053e7427_38806977?us… :
PS3, Line 143: 12
See the mention upwards. I wouldn't use a define
for a value here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4a82e0c4070da982efd6c2f15fd145393423772b
Gerrit-Change-Number: 39246
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 03 Feb 2025 19:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>