7 Mar
2024
7 Mar
'24
8:30 p.m.
Attention is currently required from: daniel, dexter, laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email )
Change subject: stream_cli: Correctly setup and free osmo_io client instance ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
I think the question daniel is racing:In the old code (pre 7e6d2e0f99ff095f4714f03b1ed991d6c9cb9c61) […]
First, the iofd must be freed and cannot be reused, otherwise it will not function correctly.
And yes, if osmo_stream_cli_open() is called again without closing, it runs into a memory leak. To guard against that, I added osmo_stream_cli_close_iofd() before calling osmo_iofd_setup().
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932
Gerrit-Change-Number: 35979
Gerrit-PatchSet: 7
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 07 Mar 2024 09:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment