dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ......................................................................
Patch Set 11:
(1 comment)
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/7/src/osmo-hnbgw/hnbgw_cn.c File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/7/src/osmo-hnbgw/hnbgw_cn.c@... PS7, Line 362: switch (((uint8_t *)msgb_l2(oph->msg))[1]) {
why such a hack here and peek into the raw msgb without the use of the decoder? Why not simply deco […]
hmm. I was hoping that at least the procedure code would be in a fixed position and we could rely on this. My idea was to safe the effort for the decoding when the procedure is not about RAB assignment. I will see how this can be solved. Probably we will have to decode it properly then.