dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw
......................................................................
Patch Set 11:
(1 comment)
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/7/src/osmo-hnbgw/hnbgw_cn.c
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/7/src/osmo-hnbgw/hnbgw_cn.c…
PS7, Line 362: switch (((uint8_t *)msgb_l2(oph->msg))[1]) {
why such a hack here and peek into the raw msgb
without the use of the decoder? Why not simply deco […]
hmm. I was hoping that at
least the procedure code would be in a fixed position and we could rely on this. My idea
was to safe the effort for the decoding when the procedure is not about RAB assignment. I
will see how this can be solved. Probably we will have to decode it properly then.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4
Gerrit-Change-Number: 26795
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 12 Jan 2022 15:49:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment