Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email )
Change subject: ASCI: Add VTY commands to control voice group/broadcast calls
......................................................................
Patch Set 16: Code-Review+1
(1 comment)
File src/host/layer23/src/mobile/vty_interface.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/5b302de9_640fbe03
PS16, Line 379: ASCI_STR
It is already added in the #define above. I renamed it
to SHOW_ASCI_STR, to make this clearer.
Not sure what do we win by having all that
ina define instead of directly, but ok...
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6
Gerrit-Change-Number: 34495
Gerrit-PatchSet: 16
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Oct 2023 11:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment