18 Jul
2023
18 Jul
'23
8:26 a.m.
Attention is currently required from: jolly, neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33674 )
Change subject: ASCI: Add option to switch on or off ASCI support ......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/msc/msc_a.h:
https://gerrit.osmocom.org/c/osmo-msc/+/33674/comment/b9bb3ad8_7dcc6550 PS4, Line 220: const char *msc_a_cm_service_type_to_use(struct gsm_network *net, enum osmo_cm_service_type cm_service_type);
I think it makes more sense to have a consistent API where the object pointer is passed, but anyway […]
I tend to agree with pespin.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753
Gerrit-Change-Number: 33674
Gerrit-PatchSet: 5
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 18 Jul 2023 06:26:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment