Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email )
Change subject: Introduce a new 'hexstr' type to represent hex-strings
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/osmocom/utils.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/1d628067_75d6…
:
PS2, Line 141: hexstr
Class names should use CamelCase in python (according to PEP 8):
https://peps.python.org/pep-0008/#class-names
Built-in Python's classes not always comply to this, but I believe user defined ones
should?
https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/cb642983_64e9…
:
PS2, Line 151: other
`... other: str) -> bool`?
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I16c0df809bc11ec0f98e8ade404f9b82072e3a06
Gerrit-Change-Number: 38023
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 04 Sep 2024 13:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes