Change in osmo-mgw[master]: IuUP->AMR: log whether converting to AMR OA or BE

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29856 ) Change subject: IuUP->AMR: log whether converting to AMR OA or BE ...................................................................... IuUP->AMR: log whether converting to AMR OA or BE Enhance the existing log message Convert IuUP -> AMR:... to Convert IuUP -> AMR OA:... (or BE) to show wether emitting Octet-Aligned or Bandwidth-Efficient. Related: SYS#5092 Change-Id: I3672d01d2879ae8820176a46454f26a4f5f584de --- M src/libosmo-mgcp/mgcp_iuup.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_iuup.c b/src/libosmo-mgcp/mgcp_iuup.c index c84b971..95487fc 100644 --- a/src/libosmo-mgcp/mgcp_iuup.c +++ b/src/libosmo-mgcp/mgcp_iuup.c @@ -274,9 +274,9 @@ return ft; } msgb_pull_to_l3(msg); - LOGP(DLMGCP, LOGL_DEBUG, "Convert IuUP -> AMR: ft %d, len %d\n", ft, msgb_l3len(msg)); if (mgcp_codec_amr_is_octet_aligned(conn_rtp_dst->end.codec)) { + LOGP(DLMGCP, LOGL_DEBUG, "Convert IuUP -> AMR OA: ft %d, len %d\n", ft, msgb_length(msg)); amr_hdr = (struct amr_hdr *) msgb_push(msg, sizeof(struct amr_hdr)); amr_hdr->cmr = 15; /* no change */ amr_hdr->f = 0; @@ -295,6 +295,7 @@ amr_data[1] |= ((ft & 0x1) << 7) | (((!fqc) & 0x1) << 6); amr_length = (osmo_amr_bits(ft) + 10 + 7) / 8; msgb_trim(msg, amr_length); + LOGP(DLMGCP, LOGL_DEBUG, "Convert IuUP -> AMR BE: ft %d, len %zd\n", ft, amr_length); } rtp_hdr = (struct rtp_hdr *) msgb_push(msg, sizeof(*rtp_hdr)); *rtp_hdr = (struct rtp_hdr){ null-- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3672d01d2879ae8820176a46454f26a4f5f584de Gerrit-Change-Number: 29856 Gerrit-PatchSet: 2 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged