osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33737 )
Change subject: USRPDevice:updateAlignment: remove byteswap code ......................................................................
USRPDevice:updateAlignment: remove byteswap code
After upgrading our CI environment to use Debian 12 with GCC 12, the byteswap code fails the build with the following. I've talked to Eric about this and he recommended to just remove the code as practically nobody will use osmo-trx with a big endian system.
USRPDevice.cpp:591:30: error: 'data' is used uninitialized [-Werror=uninitialized] 591 | *wordPtr = host_to_usrp_u32(*wordPtr); | ~~~~~~~~~~~~~~~~^~~~~~~~~~
Related: OS#6057 Change-Id: I806d8c1432cb20efca1830a2752a4cbc70384b54 --- M Transceiver52M/device/usrp1/USRPDevice.cpp 1 file changed, 20 insertions(+), 2 deletions(-)
Approvals: Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved
Objections: pespin: I would prefer this is not merged as is
diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp index 5c40aa8..852b715 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.cpp +++ b/Transceiver52M/device/usrp1/USRPDevice.cpp @@ -587,8 +587,7 @@ { #ifndef SWLOOPBACK short data[] = {0x00,0x02,0x00,0x00}; - uint32_t *wordPtr = (uint32_t *) data; - *wordPtr = host_to_usrp_u32(*wordPtr); + /* FIXME: big endian */ bool tmpUnderrun;
std::vector<short *> buf(1, data);