Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/28667 )
Change subject: trxcon: introduce and use struct 'trxcon_inst'
......................................................................
Patch Set 3:
(1 comment)
File src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/fbe67fca_ee289e9e
PS3, Line 55: struct trx_instance *trx_if_open(struct trxcon_inst *trxcon,
This is a bit strange. All functions here are called
trx_if_* but receive a trxcon_inst as object. […]
This is done on purpose. The idea
is to use 'struct trxcon_inst' as the glue between different components. Here the
pointer is used as parent talloc context, plus we'll need trxcon->fi for allocating
trx_fsm as a child of it.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28667
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I23319951c56577085e1092669b5534f9d6bda48d
Gerrit-Change-Number: 28667
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jul 2022 18:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment