osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email )
Change subject: gen_makefile: fix variable assigned but never used
......................................................................
gen_makefile: fix variable assigned but never used
gen_makefile.py:147:7: F841 Local variable `l` is assigned to but never used
gen_makefile.py:313:5: F841 Local variable `target` is assigned to but never used
Change-Id: Ib938d3336d395bfed3e5194dcf86ae5d56f99984
---
M gen_makefile.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, approved; Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
diff --git a/gen_makefile.py b/gen_makefile.py
index 22882bd..18af686 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -144,7 +144,7 @@
def extend_dict(self, d):
for k,v in d.items():
- l = self.extend(k, v)
+ self.extend(k, v)
def read_projects_deps(path):
'Read deps config and return tuples of (project_name,
which-other-to-build-first).'
@@ -310,7 +310,6 @@
touch $@
'''
elif buildsystem == "meson":
- target = "test" if check else "compile"
test_line = ""
# TODO: currently tests don't pass in this env
# if check:
--
To view, visit
https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: Ib938d3336d395bfed3e5194dcf86ae5d56f99984
Gerrit-Change-Number: 39400
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>