1 Mar
2023
1 Mar
'23
3:01 p.m.
Attention is currently required from: iedemam, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31617 )
Change subject: utils: fix incorrect string checks in meas_db_insert() ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/utils/meas_db.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31617/comment/6c3b3c1d_f58c58a7 PS1, Line 97: if (mfm->imsi[0] != '\0')
Let's see what the others think. If people find `strlen()` more readable, I can amend the patch. […]
I'm totally happy with checking "mfm->imsi[0] != '\0'". It's clear you are speecifically checking for the string being empty.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31617
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8a41078070119bc22d594c0dfff5d98b5d16f970
Gerrit-Change-Number: 31617
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: iedemam michael@kapsulate.com
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: iedemam michael@kapsulate.com
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 01 Mar 2023 14:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: iedemam michael@kapsulate.com
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment