Attention is currently required from: laforge.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/26950 )
Change subject: logging: log to stderr when logging is not initialized
......................................................................
Patch Set 4:
(1 comment)
File src/logging.c:
https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/d35f54f3_374c7206
PS2, Line 315: * Check whether the logging framework is initialized (osmo_log_info exists)
*/
: int log_initialized(void)
: {
: if (!osmo_log_info)
: return 0;
: return 1;
: }
this is a non-inline function that does nothing else
but exporting the value of an (already global, […]
This variable is global, but I
think its not exported. I have put it as extern variable in the header file now so that I
can use it directly from the macros. I also thought of doing this, but I wasn't sure
if it is was a good idea to expose osmo_log_info.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/26950
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45
Gerrit-Change-Number: 26950
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 25 Jan 2022 16:57:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment