Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email )
Change subject: nft_kpi: add udp/2152 filtering rules separately ......................................................................
Patch Set 3:
(1 comment)
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752/comment/25dee18f_81433595?us... : PS3, Line 328: static int do_add_chain(bool uplink)
While I agree with implementing a fix, I dislike the result as done in this patch because: […]
I particularly agree with pespin's second comment. There's no reason to change from a single atomic nft_run_now call to multiple iteratively.