Attention is currently required from: pespin, dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194 )
Change subject: PCUIF: use confirmation flag in struct gsm_pcu_if_pch
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194/comment/1e7f00f1_5423d...
PS1, Line 9: see Depends
no depends in the commit msg
Patchset:
PS1:
I'm not sure about the name of the variable, see https://gerrit.osmocom.org/c/osmo-pcu/+/34190/comments/5a0bbabc_378328a0. Otherwise this patch looks good to me.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7017ca20ca7e0b77d0f363121e4f17280e39e8ac
Gerrit-Change-Number: 34194
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 24 Aug 2023 13:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment