Attention is currently required from: osmith.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27953 )
Change subject: bts_trx_vty: adjust TSC warning message
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/27953/comment/bd63ce91_e11a70d9
PS1, Line 9: libosmocore aborts when vty commands return CMD_WARNING
This is the case when parsing the config file, but not when a VTY command is received via
telnet at run-time. And in the later case we're actually falling back to the BCC
(-1).
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27953/comment/74f78ab8_7fbe2872
PS1, Line 322: ts->tsc = -1;
I would remove this line too.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27953
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I041150c9ce27caca6029ed54444562bb6cdcc57a
Gerrit-Change-Number: 27953
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 20:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment