Attention is currently required from: neels, pespin, fixeria, daniel, dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28182 )
Change subject: iuup: Rework API to support RFCI IDs != RFCI index
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/gsm/iuup.c:
https://gerrit.osmocom.org/c/libosmocore/+/28182/comment/c158722d_b11f9d00
PS3, Line 348: msgb_free(msg);
the other code path does not free msg at the end. […]
nvm, the msgb is created in osmo_iuup_tnl_prim_alloc so it makes sense.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28182
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib21cee2e30bf83dff4e167f79541796007af9845
Gerrit-Change-Number: 28182
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 May 2022 12:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment