pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29370 )
Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ......................................................................
ipaccess_close(): No need to lookup already available struct e1i_ts
Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 8 deletions(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve neels: Looks good to me, approved
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 1b8d8d0..94d2baf 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -452,15 +452,11 @@ struct e1inp_ts *e1i_ts = sign_link->ts; struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; struct e1inp_line *line = e1i_ts->line; + struct osmo_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm;
- /* line might not exist if != bsc||bts */ - if (line) { - /* depending on caller the fsm might be dead */ - struct osmo_fsm_inst* ka_fsm = ipaccess_line_ts(bfd, line)->driver.ipaccess.ka_fsm; - if (ka_fsm) - ipa_keepalive_fsm_stop(ka_fsm); - - } + /* depending on caller the fsm might be dead */ + if (ka_fsm) + ipa_keepalive_fsm_stop(ka_fsm);
e1inp_int_snd_event(e1i_ts, sign_link, S_L_INP_TEI_DN); /* the first e1inp_sign_link_destroy call closes the socket. */
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.