Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31075 )
Change subject: rlcmac: Support extending log categories in the future
......................................................................
Patch Set 2: Code-Review+1
(5 comments)
Patchset:
PS2:
Looks good to me, except a few minor [mis]alignment issues.
File src/rlcmac/ts_24_008.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31075/comment/149d0fb7_fdf77aaa
PS2, Line 386: LOGRLCMAC
alignment
File src/rlcmac/ts_44_018.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31075/comment/b518c54f_0d16c3e8
PS2, Line 650: LOGRLCMAC
alignment
File src/rlcmac/ts_44_060.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31075/comment/52fbb386_5471c3e4
PS2, Line 4908: LOGRLCMAC
alignment
https://gerrit.osmocom.org/c/libosmo-gprs/+/31075/comment/a25244bf_4e04c95f
PS2, Line 5118: LOGRLCMAC
alignment
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31075
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ba207cafeada1b174f1b085e0d1d9a38c66b0a
Gerrit-Change-Number: 31075
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jan 2023 21:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment