neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )
Change subject: add fmtp string to ptmap: allow all possible fmtp ......................................................................
Patch Set 3:
(3 comments)
File include/osmocom/mgcp/mgcp_network.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/7a20c06c_c53adb21 PS3, Line 90: char fmtp[256]; here is that char fmtp[256], it matches the storage choice of audio_name[] above.
File include/osmocom/mgcp_client/mgcp_client.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/e714e348_5c276466 PS3, Line 84: const char *fmtp; I'm a bit wobbly on the storage choice. Elsewhere I put a char fmtp[256]. So maybe also an array here instead of a pointer? It would make those structs using this completely self-contained.
Does 256 seem like a sane limit? dynamic string would have no limit...
opinions welcome.
File src/libosmo-mgcp/mgcp_sdp.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/b572064d_fb311e6a PS3, Line 59: const char *fmtp; here's another dynamic string...