View Change

3 comments:

• File include/osmocom/mgcp/mgcp_network.h:

  • Patch Set #3, Line 90: char fmtp[256];

    here is that char fmtp[256], it matches the storage choice of audio_name[] above.

• File include/osmocom/mgcp_client/mgcp_client.h:

  • Patch Set #3, Line 84: const char *fmtp;

    I'm a bit wobbly on the storage choice. Elsewhere I put a char fmtp[256].
    So maybe also an array here instead of a pointer?
    It would make those structs using this completely self-contained.

    Does 256 seem like a sane limit? dynamic string would have no limit...

    opinions welcome.

• File src/libosmo-mgcp/mgcp_sdp.c:

  • Patch Set #3, Line 59: const char *fmtp;

    here's another dynamic string...

To view, visit change 34900. To unsubscribe, or for help writing mail filters, visit settings.