23 Feb
2024
23 Feb
'24
2:28 p.m.
Attention is currently required from: arehbein, daniel, fixeria, jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email )
Change subject: osmo_io: sendmsg/recvmsg support ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Patchset:
PS3:
I've discussed this to some extent with jolly earlier today, and decided I'd want to tryo how a pur […]
yay! this looks much better from architectural point of view imho.
File src/core/osmo_io_poll.c:
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/af152d24_f00699e6 PS10, Line 69: hdr.hdr.msg_control = alloca(iofd->cmsg_size); why this change? where is hdr.cmsg now set?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I89eb519b22d21011d61a7855b2364bc3c295df82
Gerrit-Change-Number: 35068
Gerrit-PatchSet: 10
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: jolly andreas@eversberg.eu
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 23 Feb 2024 13:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment