Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31669 )
Change subject: gsm0502: add burst length definitions from chapter 5.2
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/gsm0502.h:
https://gerrit.osmocom.org/c/libosmocore/+/31669/comment/2a5b955d_3a751775
PS1, Line 36: #define GSM_NBITS_NB_GMSK_PAYLOAD 2 * 58
You say *should*, but your CR-1 looks more like
*must*? :) Can you explain why is it needed to have […]
I think shitfting
operations take precedence over multiplication? I agree this should be under parenthesis.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31669
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c38ccc2b64ba9046bb3b1221d99cc55ec493802
Gerrit-Change-Number: 31669
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Mar 2023 07:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment