Attention is currently required from: daniel, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/30632
)
Change subject: pySim-prog: clean up csv file reader function
......................................................................
Patch Set 2:
(1 comment)
File pySim-prog.py:
https://gerrit.osmocom.org/c/pysim/+/30632/comment/2d20a91f_15fa1bf6
PS2, Line 567:
this doesn't look like the error message the commitlog states. So
1) the commitlog doesn't seem to describe what the comment does, and
2) separately, I'm not sure we really want to print all the data in non-error cases
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/30632
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7ae995aa3297e77b983e59c75e1c3ef17e1d7cd4
Gerrit-Change-Number: 30632
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 16:50:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment