Attention is currently required from: pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email )
Change subject: Make NSE timing data configurable
......................................................................
Patch Set 8:
(3 comments)
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/2ed199c5_32ad987c
PS7, Line 347: extern const size_t bts_gprs_rlc_timer_templates_bytes;
why is this being removed here? it probably should be
removed in the previous commit?
Done
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/8e2e7f2f_8cab8acc
PS7, Line 1662: static const struct tdef_data gprs_ns_timer_tdef_data[7] = {
I'm still totally not understanding why do you
need this index lookup here. […]
using an array to look up these values seemed
simpler than using a dictionary with timer names
File tests/gprs_params.vty:
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/5ffc0502_64de897c
PS7, Line 36: gprs nsei 0
why did the timers dissappear here? because they are
the default values? then ACK.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie46ec5cb7095bc1dfe3effd0e76d6ccfd6bd2f3f
Gerrit-Change-Number: 31880
Gerrit-PatchSet: 8
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Dec 2023 00:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment