Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #7, Line 347: extern const size_t bts_gprs_rlc_timer_templates_bytes;

    why is this being removed here? it probably should be removed in the previous commit?

    Done

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #7, Line 1662: static const struct tdef_data gprs_ns_timer_tdef_data[7] = {

    I'm still totally not understanding why do you need this index lookup here. […]

    using an array to look up these values seemed simpler than using a dictionary with timer names

• File tests/gprs_params.vty:

  • Patch Set #7, Line 36: gprs nsei 0

    why did the timers dissappear here? because they are the default values? then ACK.

    Ack

To view, visit change 31880. To unsubscribe, or for help writing mail filters, visit settings.