Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email )
Change subject: Use talloc to allocate asn1c decoded structs ......................................................................
Patch Set 2:
(1 comment)
File src/tcap.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/31437194_3430... : PS2, Line 29: vo ok, this is differnt from how we havndle talloc_asn1_ctx in libasn1c so far. There we do not define the symbol, just declare it extern, and rely on the application to define it (and hopefully derive it from another, more global or thread-local talloc context).
I think requiring the application to define it forces the application developer to think about where to hook up that context, where as defining it in the library will make it easy to fortget about it.
Other topic: Naming-wise, all other symbols exported by the library are called osmo_asn1_tcap_* whereas thisone forgoes the prefix. I think at some point we wanted to makes ure all symbols have meaningful namespace prefixes, and all should start with osmo_* if it's from a library?