Attention is currently required from: laforge, daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30936 )
Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd ......................................................................
Patch Set 4:
(3 comments)
File src/gb/gprs_ns2_udp.c:
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/f4e3b89c_75aa0ffd PS4, Line 183: struct osmo_sockaddr *saddr) wrong indentation
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/7284aa22_0018940d PS4, Line 225: static void handle_nsip_sendmsg(struct osmo_io_fd *iofd, int res, struct msgb *msg) if this is not needed, then pass a NULL pointer instead of this function?
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/820e7ce0_f644ed23 PS4, Line 272: .sendmsg_cb = &handle_nsip_sendmsg, = NULL