Attention is currently required from: laforge, daniel, lynxis lazus.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30936 )
Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd
......................................................................
Patch Set 4:
(3 comments)
File src/gb/gprs_ns2_udp.c:
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/f4e3b89c_75aa0ffd
PS4, Line 183: struct osmo_sockaddr *saddr)
wrong indentation
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/7284aa22_0018940d
PS4, Line 225: static void handle_nsip_sendmsg(struct osmo_io_fd *iofd, int res, struct
msgb *msg)
if this is not needed, then pass a NULL pointer instead of this function?
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/820e7ce0_f644ed23
PS4, Line 272: .sendmsg_cb = &handle_nsip_sendmsg,
= NULL
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30936
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id776d2d9f35c304620f3d5b94492148dd987f5a0
Gerrit-Change-Number: 30936
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 03 Feb 2023 15:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment