Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28602
)
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Patch Set 11:
(2 comments)
File include/osmocom/cbc/cbc_data.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/a085c0a7_d75cf225
PS10, Line 23: CBC_PEER_PROTO_SBcAP
cosmetic: missing comma
It's really arguable
whether it makes sense to add a comma at the end of the last one.
File include/osmocom/cbc/internal.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/06ed00a9_2d1bc50c
PS10, Line 30: enum sbcap_server_event {
So we have the same set of events as in enum
cbsp_server_event. […]
No, because it's not (or will not) be exactly the same
set, nor exactly the same meaning.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 11
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jul 2022 14:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment