Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 )
Change subject: tweak lots of logging ......................................................................
Patch Set 7:
(2 comments)
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/c39b412c_9febad10 PS3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n",
#define CNLINK_PRINT_FMT "cs7-%u %s <-> %s %s %s" […]
i don't see any improvement, sorry
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/b5200691_b14824d1 PS7, Line 635: hnbgw_cnlink_log_self(cnlink);
LOGP(DCN, LOGL_NOTICE, "Using " CNLINK_PRINT_FMT "\n", CNLINK_PRINT_ARGS(cnlink)); […]
I could have the identical 5-line LOG_CNLINK() statement twice. Instead I chose to have a static function and not dup those 5 lines. IMHO this is not important.