fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email )
Change subject: Fix 'update route' vty command
......................................................................
Patch Set 3:
(2 comments)
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348/comment/f84ac248_1fd87…
:
PS3, Line 344: linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)]
Something is still wrong with the interactive help:
```
OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 ?
linkset Point Code Length
OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset ?
LS_NAME Specify Destination Linkset
OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass ?
[priority] Linkset Name
OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority ?
[PRIO] Specify Priority
OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 42 ?
[qos-class] Priority
OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 42 qos-class ?
[CLASS] Specify QoS Class
[default] QoS Class
```
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348/comment/e6e376ff_7063c…
:
PS3, Line 397: return CMD_WARNING;
print an error here?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I28d3b587ae5d6ca7f494221e2bfc39357a45736d
Gerrit-Change-Number: 38348
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 15:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No