Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email )
Change subject: RTP: use new abstraction layer instead of direct osmo_ortp ......................................................................
Patch Set 2:
(3 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/4e1d2ae7_1f0c7011?usp=... : PS2, Line 2329: lchan_osmux_skipped_frame(lchan, fn_ms_adj(fn, lchan)); fn_ms_adj is also called here, so feel free to put fn_ms_adj above and modify this function too since fn_ms_adj() always returns a constant value.
File src/common/lchan.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/5297f5b7_63ae0095?usp=... : PS2, Line 590: false, bts->twjit_cfg); align to "(", like done eveyrwhere else.
https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/dfdd4abd_08776e0c?usp=... : PS2, Line 641: ia, connect_port); ah so osmo_rtp_socket_connect() actually got a string, and you are converting now this param into an in_addr. Please convert it to a osmo_sockaddr instead.